chore: Migrate from ESLint to oxlint by antonis · Pull Request #5867 · getsentry/sentry-react-native

antonis · 2026-03-23T14:38:20Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Fully replace ESLint with oxlint across the entire repository. Follows the same migration pattern as sentry-javascript#19134.

Pros

~430x faster linting — SDK lint goes from ~30s to ~70ms, making it practical to run on every save
Aligns with sentry-javascript — same tooling, same patterns, easier cross-repo maintenance
Simpler config — single .oxlintrc.json vs .eslintrc.js extending shared configs with multiple overrides
No more ESLint 9/10 migration burden — we were on ESLint 9 with ESLINT_USE_FLAT_CONFIG=false hack; ESLint 10 will drop legacy config support
~2000 fewer lockfile lines — removing the ESLint dependency tree significantly reduces yarn.lock
Fewer security resolutions — removing ESLint and its transitive dependencies eliminated several minimatch, ajv, and other resolutions that were pinned purely to fix vulnerabilities in ESLint's dependency tree
Type-aware linting enabled — oxlint-tsgolint provides type-aware rules (no-floating-promises, unbound-method, no-unsafe-member-access, etc.) with zero warnings, zero lint errors
Custom Sentry rules preserved — @sentry-internal/eslint-plugin-sdk works via oxlint's jsPlugins (no-eq-empty, no-focused-tests, no-skipped-tests, etc.)

Cons / known gaps

What's lost	Impact	Mitigation
`simple-import-sort/imports`	Import ordering will drift	`oxfmt` supports import sorting — can recover if we switch from prettier to oxfmt
`@typescript-eslint/naming-convention`	No enforcement of PascalCase types, `_` prefix on private members	No oxlint equivalent yet — automated enforcement lost
`@typescript-eslint/member-ordering`	No enforcement of class field/method ordering	No oxlint equivalent yet — automated enforcement lost
`@typescript-eslint/explicit-member-accessibility`	No enforcement of public/private/protected keywords	No oxlint equivalent yet — automated enforcement lost
`@typescript-eslint/typedef`	No enforcement of type annotations	No oxlint equivalent yet — mostly style
`@typescript-eslint/unified-signatures`	No overload consolidation check	Low impact, rarely triggers
`sdk/no-regexp-constructor` inline disable	jsPlugin rules can't be suppressed with inline comments	Disabled in config; only 2 intentional uses exist
tsgolint `alwaysStrict` diagnostic	`@sentry-internal/typescript` tsconfig sets `alwaysStrict: false` which is removed in TS 7.0/tsgolint	Lint script tolerates exactly 1 tsconfig-error; 0 lint warnings/errors enforced via `--deny-warnings`

What changed

SDK (packages/core):

Added .oxlintrc.json with rule parity to the previous ESLint config
Uses jsPlugins (experimental) for @sentry-internal/eslint-plugin-sdk custom rules
Migrated all eslint-disable inline comments to oxlint-disable format
Removed unused disable directives (rules already turned off in config)
Removed ESLint config files (.eslintrc.js, .eslintignore)
Removed dead big-data.test.ts (contained only a skipped test with no running assertions)
Enabled type-aware linting via --type-aware flag + oxlint-tsgolint (enforces no-floating-promises, unbound-method, no-unsafe-member-access, etc.)
Removed baseUrl from tsconfig.build.json (deprecated in TS 7.0, not needed with paths in TS 5.x+)
Added oxlint-disable comments for intentional no-unsafe-member-access violations in plugin/vendor code

Sample apps & perf tests:

Replaced ESLint configs with lightweight .oxlintrc.json in samples/react-native, samples/react-native-macos, samples/expo
Removed ESLint configs from performance-tests/TestAppPlain, performance-tests/TestAppSentry
Removed stale eslint-disable comments from sample app source files

Repo-wide cleanup:

Removed all ESLint devDependencies (eslint, @typescript-eslint/*, eslint-plugin-react, eslint-plugin-react-native, eslint-config-expo, etc.)
Added oxlint to root devDependencies for workspace-wide availability
Cleaned up ESLint-related yarn resolutions (removed security pins for ajv, minimatch, eslint-plugin-* that were only needed by ESLint's dependency tree)
Updated dependabot.yml: replaced typescript-eslint group with oxlint
Updated VS Code extensions: replaced vscode-eslint with oxlint
Updated scripts/update-javascript.sh: removed @sentry-internal/eslint-config-sdk

Remaining `eslint` references (all justified)

@sentry-internal/eslint-plugin-sdk — the custom Sentry lint plugin, loaded via oxlint's jsPlugins
oxlint-disable eslint(...) / typescript-eslint(...) — oxlint's rule naming convention
yarn.lock transitive deps — from @sentry-internal/eslint-plugin-sdk and expo/RN ecosystem

💡 Motivation and Context

ESLint 9 with ESLINT_USE_FLAT_CONFIG=false was a dead end — ESLint 10 drops legacy config
sentry-javascript already migrated (#19134)
~430x faster, aligns tooling across Sentry SDK repos

Closes #5615

💚 How did you test it?

All CI checks pass (Lint, Build, Test, dependency-review, codegen, bundles, TS 3.8 type check)
yarn lint passes (all 4 lerna projects + native linters)
yarn build passes
All 1172 SDK tests pass (103 suites)
All 186 tools tests pass (9 suites)
Zero unused disable directives
Zero remaining eslint-disable comments in source

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Recover import sorting (chore: Evaluate oxfmt as a prettier replacement #5878 / chore: Replace prettier with oxfmt #5880) — Replace prettier with oxfmt which has built-in import sorting.
Track oxlint rule coverage — oxlint is rapidly adding rules; naming-convention, member-ordering, explicit-member-accessibility may become available. These are the main remaining gaps where automated enforcement is lost.
Monitor oxlint releases — jsPlugin inline disable support would let us re-enable sdk/no-regexp-constructor.
Remove tsgolint alwaysStrict workaround — Once @sentry-internal/typescript drops the alwaysStrict option, the lint script wrapper can be simplified.

Replace ESLint with oxlint for ~430x faster linting (30s → 70ms). Follows the same pattern as sentry-javascript#19134. Changes: - Add .oxlintrc.json with rule parity to the previous ESLint config - Use jsPlugins for @sentry-internal/eslint-plugin-sdk custom rules - Migrate all eslint-disable comments to oxlint-disable format - Remove unused disable directives (rules already off in config) - Remove ESLint dependencies and config files - Clean up ESLint-related yarn resolutions Known gaps (same as sentry-javascript): - No import sorting (simple-import-sort has no oxlint equivalent) - No naming-convention, member-ordering, explicit-member-accessibility - sdk/no-regexp-constructor disabled (inline disable not supported for jsPlugin rules) Closes #5615 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-23T14:38:40Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

chore: Migrate from ESLint to oxlint by antonis in #5867

_{🤖 This preview updates automatically when you update the PR.}

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Removing ESLint from packages/core changed the dependency resolution tree, causing the expo sample to resolve es-iterator-helpers@1.0.19 which has a known incompatibility with eslint-plugin-react. Pinning to ^1.2.1 resolves the issue. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Remove ESLint from all sample apps (react-native, react-native-macos, expo) and performance test apps (TestAppPlain, TestAppSentry). Replace with lightweight oxlint configs for samples that had lint scripts. Also clean up root package.json: - Remove es-iterator-helpers resolution (no longer needed) - Remove eslint-plugin-ft-flow resolution - Remove @typescript-eslint/typescript-estree minimatch resolutions This fully removes ESLint from the repository. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Update dependabot.yml: replace typescript-eslint group with oxlint - Update VS Code extensions: replace vscode-eslint with oxlint extension - Update update-javascript.sh: remove @sentry-internal/eslint-config-sdk - Remove stale eslint-disable comments from sample apps - Update comments referencing ESLint in SDK source files - Downgrade react-hooks/exhaustive-deps to warn in sample configs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Sample apps reference `npx oxlint` but oxlint was only installed in packages/core. With yarn PnP, the binary isn't available to sibling workspaces. Adding it to root devDependencies makes it available to all workspaces. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Removing direct @typescript-eslint v8 dependencies caused the transitive @typescript-eslint/typescript-estree@6.21.0 (from eslint-plugin-sdk) to resolve minimatch@9.0.3 which has known ReDoS vulnerabilities. Pin to ^9.0.7 to resolve. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-24T10:30:59Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	419.43 ms	450.14 ms	30.71 ms
Size	43.75 MiB	48.08 MiB	4.32 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`4a17c8f`+dirty	406.62 ms	400.58 ms	-6.04 ms
`df1f7df`+dirty	442.64 ms	427.16 ms	-15.48 ms
`a483f9f`+dirty	396.82 ms	453.28 ms	56.46 ms
`60cd796`+dirty	445.84 ms	492.45 ms	46.61 ms
`5c16cdc`+dirty	423.48 ms	452.35 ms	28.88 ms
`80e4616`+dirty	411.58 ms	462.12 ms	50.54 ms
`55b77fc`+dirty	411.87 ms	417.16 ms	5.29 ms
`bca62c0`+dirty	414.36 ms	451.06 ms	36.70 ms
`0b64753`+dirty	448.67 ms	474.61 ms	25.94 ms
`4e6d7d7`+dirty	480.73 ms	515.73 ms	35.00 ms

App size

Revision	Plain	With Sentry	Diff
`4a17c8f`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`df1f7df`+dirty	43.75 MiB	48.08 MiB	4.33 MiB
`a483f9f`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`60cd796`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`5c16cdc`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`80e4616`+dirty	43.75 MiB	48.55 MiB	4.80 MiB
`55b77fc`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`bca62c0`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`0b64753`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`4e6d7d7`+dirty	43.75 MiB	48.40 MiB	4.64 MiB

github-actions · 2026-03-24T10:36:26Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1225.08 ms	1226.40 ms	1.31 ms
Size	3.38 MiB	4.73 MiB	1.35 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`80e4616`+dirty	1221.32 ms	1225.64 ms	4.32 ms
`818a608`+dirty	1205.76 ms	1208.00 ms	2.24 ms
`77061ed`+dirty	1233.16 ms	1234.88 ms	1.71 ms
`bef3709`+dirty	1222.07 ms	1220.24 ms	-1.83 ms
`a206511`+dirty	1185.00 ms	1186.35 ms	1.35 ms
`74979ac`+dirty	1210.49 ms	1213.31 ms	2.82 ms
`a2bb688`+dirty	1223.53 ms	1232.90 ms	9.37 ms
`8a868fe`+dirty	1221.50 ms	1230.78 ms	9.28 ms
`d590428`+dirty	1211.77 ms	1220.51 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`77061ed`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-03-24T10:59:30Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	457.62 ms	474.86 ms	17.24 ms
Size	43.94 MiB	48.93 MiB	5.00 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`70250df`+dirty	418.08 ms	480.84 ms	62.76 ms
`8d89cc9`+dirty	357.69 ms	415.79 ms	58.10 ms
`1853710`+dirty	360.67 ms	396.28 ms	35.61 ms
`55b77fc`+dirty	410.46 ms	414.11 ms	3.65 ms
`69602ce`+dirty	375.37 ms	405.28 ms	29.91 ms
`c1573b3`+dirty	355.65 ms	448.82 ms	93.17 ms
`90afdd3`+dirty	367.79 ms	404.84 ms	37.05 ms
`955f2eb`+dirty	388.13 ms	433.56 ms	45.44 ms
`80e4616`+dirty	427.31 ms	461.15 ms	33.84 ms
`276d348`+dirty	356.30 ms	405.27 ms	48.97 ms

App size

Revision	Plain	With Sentry	Diff
`70250df`+dirty	43.94 MiB	48.91 MiB	4.97 MiB
`8d89cc9`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`1853710`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`55b77fc`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`69602ce`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`c1573b3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`90afdd3`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`955f2eb`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`80e4616`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`276d348`+dirty	7.15 MiB	8.42 MiB	1.26 MiB

packages/core/test/vendor/base64-js/big-data.test.ts

…s to error The big-data.test.ts file contained only a skipped test with no running assertions. Removing it and promoting sdk/no-skipped-tests back to error since there are no more intentional test.skip usages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-24T14:39:46Z

	Fails
🚫	Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

	Warnings
⚠️	🤖 Replay Stubs Check ✅ No changes detected in replay-stubs.jar All file contents are identical (verified by SHA-256 hash comparison).

Generated by 🚫 dangerJS against 089e0c9

Now that TypeScript is upgraded to 5.9.3, enable type-aware linting via oxlint --type-aware + oxlint-tsgolint. This enforces rules like no-floating-promises, unbound-method, and no-unsafe-member-access that require type information. - Add oxlint-tsgolint devDependency - Add tsconfig.lint.json for tsgolint (avoids alwaysStrict compat issue with @sentry-internal/typescript tsconfig) - Enable --type-aware and --deny-warnings in lint scripts - Disable await-thenable (not in original ESLint config, false positives on mocks) - Add oxlint-disable comments for intentional violations Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

express@4.19.2 is no longer in the dependency tree. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

packages/core/src/js/sdk.tsx

The merge with main lost the !__DEV__ condition in the __SENTRY_OPTIONS__ check, which would have changed behavior in dev builds by skipping native auto-initialization. Restore the guard and update tests to match main's version that properly tests dev vs release build behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-26T16:20:38Z

packages/core/src/js/client.ts

      dsn: this.getDsn(),
      tunnel: undefined,
    });
-    // eslint-disable-next-line @typescript-eslint/no-floating-promises


Missing oxlint-disable for intentional floating promise

Low Severity

The eslint-disable-next-line @typescript-eslint/no-floating-promises comment was removed from this.sendEnvelope(envelope) without being migrated to an oxlint-disable-next-line equivalent. sendEnvelope returns PromiseLike<TransportMakeRequestResponse>, making this an intentional fire-and-forget floating promise. Other identical patterns in the same PR were properly migrated (e.g., reactnativeprofiler.tsx line 60, modal.tsx line 426). The typescript/no-floating-promises rule is configured as "error" for TS files in .oxlintrc.json.

antonis and others added 6 commits March 23, 2026 15:45

chore(core): Add sdk/no-focused-tests and sdk/no-skipped-tests rules

66bf368

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge branch 'main' into antonis/oxlint

965145f

antonis requested a review from logaretm March 24, 2026 10:03

antonis added ready-to-merge Triggers the full CI test suite skip-changelog labels Mar 24, 2026

antonis changed the title ~~chore(core): Migrate from ESLint to oxlint~~ chore: Migrate from ESLint to oxlint Mar 24, 2026

lucas-zimerman reviewed Mar 24, 2026

View reviewed changes

packages/core/test/vendor/base64-js/big-data.test.ts Outdated Show resolved Hide resolved

antonis removed the ready-to-merge Triggers the full CI test suite label Mar 24, 2026

ci: Retrigger checks

c39e3e6

This was referenced Mar 24, 2026

chore: Upgrade TypeScript from 4.9.5 to 5.x #5877

Closed

chore: Evaluate oxfmt as a prettier replacement #5878

Open

chore: Replace prettier with oxfmt #5880

Open

chore(core): Upgrade TypeScript from 4.9.5 to 5.9.3 #5886

Merged

antonis and others added 5 commits March 26, 2026 12:00

Merge main into antonis/oxlint

79b90c5

Merge main into antonis/oxlint

7f45543

chore: Remove stale express/path-to-regexp resolution

6f74c8c

express@4.19.2 is no longer in the dependency tree. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into antonis/oxlint

8d1eb87

antonis marked this pull request as ready for review March 26, 2026 15:58

antonis requested a review from alwx as a code owner March 26, 2026 15:58

cursor bot reviewed Mar 26, 2026

View reviewed changes

packages/core/src/js/sdk.tsx Show resolved Hide resolved

antonis and others added 2 commits March 26, 2026 17:12

Merge remote-tracking branch 'origin/main' into antonis/oxlint

089e0c9

cursor bot reviewed Mar 26, 2026

View reviewed changes

Uh oh!

Conversation

antonis commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

Pros

Cons / known gaps

What changed

Remaining eslint references (all justified)

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions bot commented Mar 24, 2026

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 24, 2026

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 24, 2026

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Replay Stubs Check

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 26, 2026

Choose a reason for hiding this comment

Missing oxlint-disable for intentional floating promise

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

antonis commented Mar 23, 2026 •

edited

Loading

Remaining `eslint` references (all justified)

github-actions bot commented Mar 23, 2026 •

edited

Loading

github-actions bot commented Mar 24, 2026 •

edited

Loading